How can we help you today? How can we help you today?

False positive on optimization recommendation ?

Hello,

the following image shows the profiler recommending optimization on a method, can you please explain why ?

optimise.png

the largest percent of time is a call to a callback method that updates a label on the splash screen. The whole method is only a hand full of lines and the call back is only 3 lines of code, in my thinking I would consider that a false positive ? what is the methodology behind the detection of code that can be optimized ?

thanks
Lexicon
0

Comments

4 comments

Sort by
  • StephenC
    Hi Paul,

    the suggestions for optimisations won't always be accurate. I'm not sure of the exact heuristic that's used but by its nature it will lead to some methods being suggested which may be okay from the user's point of view.

    They shouldn't be taken as gospel that it needs to be optimised but are only offered as possibilities.

    Stephen
    StephenC
    0
  • Lexicon
    Hi Stephen,

    I understand what you are saying and had already made the assumption, I am trying to understand the results though, I feel that the 31.916% of time is erroneous, the LoadPreferencesFromRegistry() method is not showing a hit count, yet it has been called, and the code behind setting the selected tab page is fairly lengthy [eg, xtraTab_SelectedTabChanged()], so I would have thought the numbers would have come out different.

    I will use the call tree to see what is happening behind the scenes to see if that can shed light for me.

    Thanks.
    Lexicon
    0
  • StephenC
    Hi Paul,

    there seems to be something strange going on there. It almost looks like an off by 1 error with the source file but that wouldn't explain it.

    In the tree view it shows the Form Load calling a method 'setSplashText' which I don't see anywhere in the code view. It's almost as if the source for the code view has changed or something or that the source file it's showing isn't the right one. Did anything change during profiling by any chance? The 'End Sub' shouldn't be showing a hit count so there's definitely a problem.

    We will try and find out what's causing this and if you have any thoughts on possible causes then let us know.

    Hopefully we will have the ability to save results soon in which case you will be able to save such oddities and send them to us for further inspection.


    Stephen
    StephenC
    0
  • Lexicon
    Hi Stephen,

    in this particular case the source was not modified, the IDE was not open, it was a clean run. It is not the first time I have had something like this happen, if you recall early in the EAP I had some strange results very similar.

    I will let you know if I find anything in the meantime.
    Lexicon
    0

Add comment

Please sign in to leave a comment.