Pattern for reporting exception and continuing

• 
  Can you just catch and handle the exception in your code, then just throw it again? That should send it down to the SmartAssembly unhandled exception handler the same as if it was never caught, as far as I know.

  Brian Donahue May 04, 2011 05:24

  - 0 +
• 
  I realised I was thinking about this in completely the wrong way. Whatever code I had in my OnReportException(ReportExceptionEventArgs e) handler is what I should be putting into my catch brace - thanks.

  fostandy May 04, 2011 08:30

  - 0 +
• 
  actually I can't - no way to actually send an exception report from outside of the OnReportException handler.
  
  Brian: My question was basically what should I put in my catch (Exception e) {} block to be able to set ReportExceptionEventArgs#TryToContinue = true; ?
  
  I'm not seeing an immediate way to deal with this except either with static variables or wrapping the exception. The latter is the cleanest solution I can think of but it is still not particularly elegant.
  
  This is more of a design question than a technical smartassembly question, although I do want to make sure I'm not missing something obvious in the API.

  fostandy May 05, 2011 01:20

  - 0 +
• 
  I don't understand. If you have caught the exception yourself, you don't need to "try to continue" as you have handled the exception and can continue?

  Brian Donahue May 05, 2011 06:18

  - 0 +
• 
  I want to report the exception, and then continue.
  
  I don't see how I can report the exception without re-throwing it for SmartAssembly to handle via the OnReportException method. And once rethrown I don't see any way to control the continue parameters short of wrapping it in a customized exception.

  fostandy May 10, 2011 12:08

  - 0 +
• 
  Just set the TryToContinue property in OnReportException and that should do the job, as I understand.

  	public class UnhandledExceptionHandlerWithoutUI : UnhandledExceptionHandler
  	{
  protected override void OnReportException(ReportExceptionEventArgs e)
  		{
                                        //Put your custom exception form logic here
  			for (int i=0; i<3; i++)
  			{
  				if (e.SendReport()) break;
  			}
  			e.TryToContinue = true;
  		}
  }
  

  Brian Donahue May 10, 2011 12:16

  - 0 +
• 
  Ok, in my usercode i have this
  

  public void Foo()
  {
      // here I would like to throw an exception and continue
     throw new Exception("I want this to report, but continue");
  }
  
  public void Foo2()
  {
     throw new Exception("I want this to report, and not continue");
  }
  
  public class UnhandledExceptionHandlerWithoutUI : UnhandledExceptionHandler 
     { 
  protected override void OnReportException(ReportExceptionEventArgs e) 
        { 
             // handle/report it
  
             if (/* WHAT GOES HERE? */)
                e.TryToContinue = false;
             else
                e.TryToContinue = true;
          }
  }
  

  
  My question is, what goes into the /* WHAT GOES HERE? */ that will make calls to Foo() and Foo2() behave as I desire?

  fostandy May 12, 2011 05:29

  - 0 +
• 
  I've handled this in the past by declaring my own type of exception and checking the exception type in OnReportException.

  try{/*something*/}
  catch (Exception e){
  throw new ReportOnlyException("I only want to report this");
  }
  ...
   protected override void OnReportException(ReportExceptionEventArgs e)
          {
              if (e.Exception is ReportOnlyException)
              e.TryToContinue=true;
              else e.TryToContinue=false;
           }
  

  I guess you could also set something in the exception's Data property and check that.

  Brian Donahue May 12, 2011 06:16

  - 0 +

Add comment

Please sign in to leave a comment.